Skip to content

fix incorrect default value description for output_xoffset #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eshizhan wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix incorrect default value description for output_xoffset #2188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docs/config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ option | argument | descripti
output_binlog_position | BOOLEAN | records include binlog position | false
output_gtid_position | BOOLEAN | records include gtid position, if available | false
output_commit_info | BOOLEAN | records include commit and xid | true
output_xoffset | BOOLEAN | records include virtual tx-row offset | false
output_xoffset | BOOLEAN | records include virtual tx-row offset | true
output_push_timestamp | BOOLEAN | records are timestamped with a high-precision value before being sent to the producer | false
output_nulls | BOOLEAN | records include fields with NULL values | true
output_server_id | BOOLEAN | records include server_id | false
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/zendesk/maxwell/MaxwellConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ protected MaxwellOptionParser buildOptionParser() {
.withOptionalArg().ofType(Boolean.class);
parser.accepts( "output_commit_info", "include 'commit' and 'xid' field. default: true" )
.withOptionalArg().ofType(Boolean.class);
parser.accepts( "output_xoffset", "include 'xoffset' (row offset inside transaction) field. depends on '--output_commit_info'. default: false" )
parser.accepts( "output_xoffset", "include 'xoffset' (row offset inside transaction) field. depends on '--output_commit_info'. default: true" )
.withOptionalArg().ofType(Boolean.class);
parser.accepts( "output_nulls", "include data fields with NULL values. default: true" )
.withOptionalArg().ofType(Boolean.class);
Expand Down