[sberbank-by]: Исправить дубли операций Сбербанк BY при пополнении вкладов#1075
Open
Kabaye wants to merge 1 commit into
Open
[sberbank-by]: Исправить дубли операций Сбербанк BY при пополнении вкладов#1075Kabaye wants to merge 1 commit into
Kabaye wants to merge 1 commit into
Conversation
Kabaye
force-pushed
the
fix/sberbank-another-eventid-fallback
branch
from
472118d to
5822491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что изменилось
Исправлен узкий кейс в Sberbank BY: при онлайн-пополнении вклада/копилки банк отдает в
/eventsдве стороны операции:Плагин уже видел реальное зачисление, но дополнительно дорисовывал синтетическую сторону
Checking, из-за чего операция могла задваиваться в приложении.Теперь, если целевая сторона операции уже пришла из
/events, карточное списание группируется с ней в один transfer. Fallback с синтетическимCheckingсохранен для случаев, когда целевая сторона не пришла.Проверка
yarn jest --testMatch "**/src/plugins/sberbank-by/__tests__/**/*.test.js"yarn lint src/plugins/sberbank-by/converters.js src/plugins/sberbank-by/__tests__/converters/transactions/convertTransactionsFunc.test.jsgit diff --check master...HEAD