[altabanka-rs] new auth flow and data API#1082
Open
flater1c wants to merge 1 commit into
Open
Conversation
flater1c
changed the title
Migrate from the retired altabanka.24x7.rs HTML scraping to the new online.altabanka.rs (Holos) JSON API: - Login via username + one-time code (OTP) from the mobile app; UserInteractionError when running in background. - Accounts from GetAllAccountBalance; account operations from GetTransactionalAccountTurnover (card rows excluded). - Card operations from GetCardTurnover (real transaction date, original-currency invoice, per-currency queries). - Pending authorizations from GetTransactionalAccountReservedFunds as hold. - Tests updated to JSON fixtures.
flater1c
force-pushed
the
altabanka-rs-new-auth-flow
branch
from
4417edf to
b5b25e2
Compare
Author
|
Hello @skvav, may I ask you for a review please? |
|
@skvav |
|
Hey! I just noticed this PR for the Alta Banka plugin fix. I was so desperate I almost started learning TypeScript myself 😄 The implementation looks really solid, and it covers a lot. I’m really looking forward to seeing it merged! @skvav Since the current plugin is broken after the bank update, could you please take a look when you have a chance? I think it would help get the fix merged sooner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the
altabanka-rsplugin to the bank's new internet banking platform. The previousaltabanka.24x7.rsHTML-scraping flow no longer works because the bank migrated toonline.altabanka.rs(Holos) with a JSON API and a different login method.Changes
GetEnvironmentVariablesand sent asX-Holos-RequestToken.UserInteractionErroris thrown when running in background.DataService.svc/GetAllAccountBalance.DataService.svc/GetTransactionalAccountTurnover(card rows excluded, they are taken from card turnover).DataService.svc/GetCardTurnover— provides the real transaction date and the original-currency amount; queried per currency. Foreign purchases keep the domestic RSD sum plus an original-currency invoice.DataService.svc/GetTransactionalAccountReservedFundsimported ashold.fetchApi/api/parsers/converters/modelslayout;codeRequiredset totrue.Testing
yarn test altabanka-rspasses (lint + types + 31 unit tests). Verified live against a real account viayarn start altabanka-rs: accounts, RSD/foreign card operations with real dates, refunds and pending authorizations.Issue #1079