Skip to content

tronscan: fix data loss in transaction/transfer pagination #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyJIJIEP wants to merge 4 commits into
base: master
Choose a base branch
from
Open

tronscan: fix data loss in transaction/transfer pagination #1086

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71da3fe
tronscan: fix data loss in transaction/transfer pagination
KyJIJIEP Jun 29, 2026
4336649
tronscan: correct account/tokens limit cap to 200
KyJIJIEP Jun 30, 2026
b4b4759
tronscan: align window cap with documented start+limit <= 10000
KyJIJIEP Jun 30, 2026
49adc9d
tronscan: simplify window pagination per review
KyJIJIEP Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
200 changes: 115 additions & 85 deletions src/plugins/tronscan/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,114 +116,144 @@ export class TronscanApi {
public async fetchTokens (wallet: string): Promise<SupportedTokenInfo[]> {
const response = await this.fetchApi<{ data: TokenInfo[] }>('account/tokens', {
address: wallet,
limit: 999
limit: 200
},
(res) => typeof res.body === 'object' && res.body != null && 'data' in res.body
)

return response.body.data.filter(isSupportedToken)
}

public async fetchTransactions (wallet: string, fromDate: Date, toDate?: Date): Promise<Map<string, TronTransaction>> {
const transactions = new Map<string, TronTransaction>()
let start = 0
const limit = 50

while (true) {
const response = await this.fetchApi<{ data: TronTransaction[], total: number }>('transaction', {
address: wallet,
start_timestamp: fromDate.valueOf(),
end_timestamp: toDate?.valueOf(),
limit,
start,
sort: '-timestamp'
})

for (const transaction of response.body.data) {
transactions.set(transaction.hash, transaction)
}

if (start + limit >= response.body.total) {
break
}

start += limit
}
// Tronscan enforces `start + limit <= 10000` for a single (address,
// time-range) query. Once a window reaches that ceiling we move its upper
// bound (end_timestamp) back to the oldest record seen and keep going, so
// the full history is retrieved without leaving gaps.
private static readonly PAGE_LIMIT = 50
private static readonly WINDOW_CAP = 10000

return transactions
}

public async fetchTokenTransfers (wallet: string, fromDate: Date, toDate?: Date): Promise<Transfer[]> {
const transfers: Transfer[] = []
let start = 0
const limit = 50
private async fetchPaginated<Body, Item> (
url: string,
params: Record<string, string | number | boolean | undefined>,
fromDate: Date,
toDate: Date | undefined,
extract: (body: Body) => Item[],
getId: (item: Item) => string,
getTimestamp: (item: Item) => number
): Promise<Item[]> {
const limit = TronscanApi.PAGE_LIMIT
const cap = TronscanApi.WINDOW_CAP
const collected: Item[] = []
const seen = new Set<string>()
let windowEnd = toDate?.valueOf()

while (true) {
const response = await this.fetchApi<{ total: number, token_transfers: Transfer[] }>('token_trc20/transfers', {
relatedAddress: wallet,
start_timestamp: fromDate.valueOf(),
end_timestamp: toDate?.valueOf(),
limit,
start,
sort: '-timestamp'
})

for (const t of response.body.token_transfers) {
transfers.push({
transaction_id: t.transaction_id,
block_ts: t.block_ts,
from_address: t.from_address,
to_address: t.to_address,
quant: t.quant,
tokenInfo: t.tokenInfo
let start = 0
let oldestTs: number | undefined
let reachedCap = false

while (true) {
// A page would cross the `start + limit <= 10000` ceiling: older
// records remain but are unreachable by offset, so narrow the window.
if (start + limit > cap) {
reachedCap = true
break
}

const response = await this.fetchApi<Body>(url, {
...params,
start_timestamp: fromDate.valueOf(),
end_timestamp: windowEnd,
limit,
start
})

const items = extract(response.body)

for (const item of items) {
const ts = getTimestamp(item)
if (oldestTs === undefined || ts < oldestTs) {
oldestTs = ts
}
const id = getId(item)
// De-duplicate: the offset is not perfectly stable and the record
// on the window boundary is re-fetched when we narrow the window.
if (!seen.has(id)) {
seen.add(id)
collected.push(item)
}
}

// A non-full page means this window is drained (full pages are served
// until the data runs out).
if (items.length < limit) {
break
}

start += limit
}

if (start + limit >= response.body.total) {
// The window was fully drained, so there is nothing older to fetch.
if (!reachedCap || oldestTs === undefined) {
break
}

start += limit
// Guard against making no progress (e.g. many records share a timestamp).
if (windowEnd !== undefined && oldestTs >= windowEnd) {
break
}
windowEnd = oldestTs
}

return transfers
return collected
}

public async fetchTronTransfers (wallet: string, fromDate: Date, toDate?: Date): Promise<Transfer[]> {
const transfers: Transfer[] = []
let start = 0
const limit = 50

while (true) {
const response = await this.fetchApi<{ tokenInfo: TokenInfo, page_size: number, data: TronTransfer[] }>(
'transfer/trx', {
direction: 0,
address: wallet,
start_timestamp: fromDate.valueOf(),
end_timestamp: toDate?.valueOf(),
limit,
start
})
public async fetchTransactions (wallet: string, fromDate: Date, toDate?: Date): Promise<Map<string, TronTransaction>> {
const items = await this.fetchPaginated<{ data: TronTransaction[] }, TronTransaction>(
'transaction',
{ address: wallet, sort: '-timestamp' },
fromDate,
toDate,
(body) => body.data,
(tx) => tx.hash,
(tx) => tx.timestamp
)

for (const t of response.body.data) {
transfers.push({
transaction_id: t.hash,
block_ts: t.block_timestamp,
from_address: t.from,
to_address: t.to,
quant: t.amount,
tokenInfo: response.body.tokenInfo
})
}
const transactions = new Map<string, TronTransaction>()
for (const transaction of items) {
transactions.set(transaction.hash, transaction)
}

if (response.body.page_size < limit) {
break
}
return transactions
}

start += limit
}
public async fetchTokenTransfers (wallet: string, fromDate: Date, toDate?: Date): Promise<Transfer[]> {
return await this.fetchPaginated<{ token_transfers: Transfer[] }, Transfer>(
'token_trc20/transfers',
{ relatedAddress: wallet, sort: '-timestamp' },
fromDate,
toDate,
(body) => body.token_transfers,
(t) => t.transaction_id,
(t) => t.block_ts
)
}

return transfers
public async fetchTronTransfers (wallet: string, fromDate: Date, toDate?: Date): Promise<Transfer[]> {
return await this.fetchPaginated<{ tokenInfo: TokenInfo, page_size: number, data: TronTransfer[] }, Transfer>(
'transfer/trx',
{ direction: 0, address: wallet },
fromDate,
toDate,
(body) => body.data.map((t) => ({
transaction_id: t.hash,
block_ts: t.block_timestamp,
from_address: t.from,
to_address: t.to,
quant: t.amount,
tokenInfo: body.tokenInfo
})),
(t) => t.transaction_id,
(t) => t.block_ts
)
}
}

Expand Down