Write PID file after forking and before exiting.#137
Open
quentinmit wants to merge 1 commit intozephyr-im:masterfrom
Open
Write PID file after forking and before exiting.#137quentinmit wants to merge 1 commit intozephyr-im:masterfrom
quentinmit wants to merge 1 commit intozephyr-im:masterfrom
Conversation
achernya
requested changes
Aug 26, 2020
Member
achernya
left a comment
achernya
left a comment
There was a problem hiding this comment.
Can you update the commit description with why you're doing this? I assume this is for systemd compatibility / to make the PID file actually reflect the PID of the running process.
| @@ -414,12 +414,13 @@ init_hm(void) | |||
| #ifndef DEBUG | |||
| if (!inetd && !nofork) | |||
Member
There was a problem hiding this comment.
Can you add { } to this statement? I don't like unblanaced if-else clauses where one has it and the other does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.