Skip to content

[Backport v4.3-branch] MCTP over I2C+GPIO fixes #117354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 3 commits into
base: v4.3-branch
Choose a base branch
from
+16 −3
Open

[Backport v4.3-branch] MCTP over I2C+GPIO fixes #117354

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b36fff5
pmci: mctp: Fix off-by-one and wrap over issue on I2C+GPIO
edersondisouza Aug 10, 2026
0ba811b
pmci: mctp: Ensure there's a packet to be read on I2C+GPIO
edersondisouza Aug 10, 2026
c219383
pmci: mctp: Reset "register" after I2C STOP
edersondisouza Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions subsys/pmci/mctp/mctp_i2c_gpio_target.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ int mctp_i2c_gpio_target_read_requested(struct i2c_target_config *config, uint8_
*val = pkt_len;
break;
case MCTP_I2C_GPIO_TX_MSG_ADDR:
if (b->tx_pkt == NULL || b->tx_pkt->start >= b->tx_pkt->end) {
LOG_WRN("No packet to send");
ret = -EIO;
break;
}
b->rxtx = true;
*val = b->tx_pkt->data[b->tx_pkt->start];
b->tx_idx = b->tx_pkt->start;
Expand All @@ -113,17 +118,21 @@ int mctp_i2c_gpio_target_read_processed(struct i2c_target_config *config, uint8_
struct mctp_binding_i2c_gpio_target *b =
CONTAINER_OF(config, struct mctp_binding_i2c_gpio_target, i2c_target_cfg);

b->tx_idx += 1;

if (b->reg_addr != MCTP_I2C_GPIO_TX_MSG_ADDR) {
goto out;
}

if (b->tx_idx > b->tx_pkt->end) {
if (b->tx_pkt == NULL) {
LOG_WRN("No packet to process");
return -EIO;
}

if (b->tx_idx + 1 >= b->tx_pkt->end) {
LOG_WRN("rrp past end reg %d", b->reg_addr);
return -EIO;
}

b->tx_idx += 1;
*val = b->tx_pkt->data[b->tx_idx];

out:
Expand Down Expand Up @@ -164,6 +173,10 @@ int mctp_i2c_gpio_target_stop(struct i2c_target_config *config)
}
}

/* After stop, a new register must be selected */
b->reg_addr = MCTP_I2C_GPIO_INVALID_ADDR;
b->rxtx = false;

return 0;
}

Expand Down