drivers: i3c: npcx: Fix warning and verbosity - #117357
Open
edersondisouza wants to merge 2 commits into
Open
Conversation
npcx_i3c_target_ibi_raise() is defined unconditionally, but the .ibi_raise entry of the driver API that references it sits inside a CONFIG_I3C_USE_IBI guard. Building with CONFIG_I3C_USE_IBI=n leaves the function unreferenced and the compiler warns: warning: 'npcx_i3c_target_ibi_raise' defined but not used [-Wunused-function] Wrap the function in the same guard as its only user. Assisted-by: Copilot-CLI:claude-opus-5 Signed-off-by: Ederson de Souza <ederson.desouza@intel.com>
An underrun maybe expected if, for instance, the controller is polling to know if there's something to read. However, current logging was logging URUNNACK (the underrun condition) with error level, which was annoying (many messages per second depending on the controller's polling rate). This patch changes it so that underruns are only logged at debug level. Assisted-by: Copilot-CLI:claude-opus-5 Signed-off-by: Ederson de Souza <ederson.desouza@intel.com>
zephyrbot
requested review from
ChiHuaL,
MulinChao,
TomChang19,
XenuIsWatching,
alvsun,
dcpleung,
fabiobaltieri and
keith-zephyr
August 25, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues:
Found those when playing with polling MCTP over I3C (
CONFIG_MCTP_I3C_CONTROLLER_POLLING_MODE=y).