nuvoton-npcx: use portable IRQ pending API in drivers/socs - #117381
Open
nashif wants to merge 2 commits into
Open
nuvoton-npcx: use portable IRQ pending API in drivers/socs#117381nashif wants to merge 2 commits into
nashif wants to merge 2 commits into
Conversation
nashif
commented
Aug 25, 2026
nashif
commented
Member
- drivers: peci: npcx: use portable IRQ pending API
- mgmt: ec_host_cmd: shi_npcx: use portable IRQ pending API
Replace direct NVIC_SetPendingIRQ()/NVIC_ClearPendingIRQ() calls with k_irq_set_pending()/k_irq_clear_pending(), dropping the dependency on cmsis_core.h where nothing else needed it. These platforms are plain-NVIC Cortex-M, so the pending-state capabilities are always available where this code builds. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Replace direct NVIC_SetPendingIRQ()/NVIC_ClearPendingIRQ() calls with k_irq_set_pending()/k_irq_clear_pending(), dropping the dependency on cmsis_core.h where nothing else needed it. These platforms are plain-NVIC Cortex-M, so the pending-state capabilities are always available where this code builds. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
zephyrbot
added
area: ec_host_cmd
area: PECI
zephyrbot
requested review from
ChiHuaL,
MulinChao,
TomChang19,
VenkatKotakonda,
albertofloyd,
alvsun,
fabiobaltieri,
keith-zephyr and
niedzwiecki-dawid
August 25, 2026 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.