drivers: counter: xlnx_ttc: use portable IRQ pending API - #117386
Open
nashif wants to merge 1 commit into
Open
Conversation
Replace direct NVIC pending-state calls with k_irq_set_pending()/ k_irq_is_pending()/k_irq_clear_pending(), dropping the dependency on cmsis_core.h where nothing else needed it. This driver called arm_gic_irq_set_pending() directly; the portable API removes the GIC-specific dependency. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
zephyrbot
requested review from
FelixWang47831,
Holt-Sun,
henrikbrixandersen,
ibirnbaum,
kedareswararao,
michalsimek,
neeliajay and
nordic-krch
August 26, 2026 00:01
|
You have been identified as a likely reviewer for the code this pull request changes, but could not be added to its review request automatically. Please review it if you are able to. |
kedareswararao
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct NVIC pending-state calls with k_irq_set_pending()/
k_irq_is_pending()/k_irq_clear_pending(), dropping the dependency on
cmsis_core.h where nothing else needed it.
This driver called arm_gic_irq_set_pending() directly; the portable
API removes the GIC-specific dependency.
Assisted-by: Claude:claude-opus-5
Signed-off-by: Anas Nashif anas.nashif@intel.com