tests: gpio: it8xxx2_v2: include arch_interface.h in cpu.h shim - #117392
Merged
nashif merged 1 commit intoAug 26, 2026
Conversation
The test replaces zephyr/arch/cpu.h with a shim that includes posix/arch.h directly. Since irq.h gained the inline k_irq_* wrappers that call arch_irq_lock() and friends, the shim breaks the build: the posix arch header pulls in irq.h before it defines those functions, and the real cpu.h only avoids this by including arch_interface.h, which declares the arch_irq_* prototypes, ahead of the arch header. Mirror the real cpu.h in the shim: include arch_interface.h first and add the matching include guard, which is needed because arch_interface.h includes cpu.h back. The hand-written dynamic interrupt prototypes are provided by arch_interface.h, so drop them. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
added
the
Hotfix
zephyrbot
added
area: GPIO
area: Tests
8 tasks
jhedberg
approved these changes
Aug 26, 2026
kartben
approved these changes
Aug 26, 2026
aescolar
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test replaces zephyr/arch/cpu.h with a shim that includes
posix/arch.h directly. Since irq.h gained the inline k_irq_* wrappers
that call arch_irq_lock() and friends, the shim breaks the build: the
posix arch header pulls in irq.h before it defines those functions,
and the real cpu.h only avoids this by including arch_interface.h,
which declares the arch_irq_* prototypes, ahead of the arch header.
Mirror the real cpu.h in the shim: include arch_interface.h first and
add the matching include guard, which is needed because
arch_interface.h includes cpu.h back. The hand-written dynamic
interrupt prototypes are provided by arch_interface.h, so drop them.
Signed-off-by: Anas Nashif anas.nashif@intel.com