Overhaul the log records flow#156
Merged
inge4pres merged 8 commits intoMay 21, 2026
Merged
Conversation
This was referenced May 10, 2026
e3e6224 to
f2f9cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #155
Review the log records flow, fix lifetime issues, and simplify allocation and cleaning.
Fix
previously,
toReadableduplicated some external strings (body and severity text) but shallow-copied the strings in the attributes, introducing a foot-gun as it appears duplicated but relies on externally-owned data.Improvement
After reviewing the flow (see
.md), it became clear that:emitreturnsFurthermore, cleaning requires iterating over all log records, testing for presence of optionals, and, if we were to properly duplicate all strings, iterate over attributes, etc. While in fact, the log records in a batch are all freed at the same time
So this PR:
asReadablewhich makes a cheaper shallow copy, without any duplication and any cleaning required, for the SimpleLogProcessortoReadablea full deep copyMisc
Minor improvements are also included:
@memcpyinstead of a loop in the BatchLogProcessorappendSliceinstead of a loop when copying attributes into an ArrayList