Assume by default that most bindings are const

This fixes the resolved types of pointers to:
- char literals,
- number literals,
- enum literals,
- string literals,
- error values,
- builtin function calls,
- and probably more

Author: FnControlOption

src/analysis.zig

@@ -2825,7 +2825,7 @@ fn resolveBindingOfNodeUncached(analyser: *Analyser, node_handle: NodeWithHandle
 
         else => return .{
             .type = try analyser.resolveTypeOfNodeUncached(node_handle) orelse return null,
-            .is_const = false,
+            .is_const = true,
         },
     }
 }

tests/analysis/address_of.zig

@@ -1,3 +1,31 @@
+const char_literal_pointer = &'a';
+//    ^^^^^^^^^^^^^^^^^^^^ (*const comptime_int)()
+
+const int_literal_pointer = &0;
+//    ^^^^^^^^^^^^^^^^^^^ (*const comptime_int)()
+
+const enum_literal_pointer = &.foo;
+//    ^^^^^^^^^^^^^^^^^^^^ (*const @Type(.enum_literal))()
+
+const string_literal_pointer = &"foo";
+//    ^^^^^^^^^^^^^^^^^^^^^^ (*const *const [3:0]u8)()
+
+// zig fmt: off
+const multiline_string_literal_pointer = &
+//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ (*const *const [3:0]u8)()
+    \\foo
+;
+// zig fmt: on
+
+const error_value_pointer = &error.Foo;
+//    ^^^^^^^^^^^^^^^^^^^ (*const error{Foo})()
+
+const builtin_as_0 = &@as(i32, 0);
+//    ^^^^^^^^^^^^ (*const i32)()
+
+const builtin_as_1 = &@as(StructType, mutable_struct);
+//    ^^^^^^^^^^^^ (*const StructType)()
+
 const StructType = struct {
     foo: i32,
     const const_decl: bool = true;

tests/analysis/array.zig

@@ -20,6 +20,9 @@ var runtime_index: usize = 5;
 const some_array: [length]u8 = undefined;
 //    ^^^^^^^^^^ ([3]u8)()
 
+const some_array_pointer = &[3]u8{ 1, 2, 3 };
+//    ^^^^^^^^^^^^^^^^^^ (*const [3]u8)()
+
 const some_unsized_array: [unknown_length]u8 = undefined;
 //    ^^^^^^^^^^^^^^^^^^ ([?]u8)()
 
@@ -94,9 +97,8 @@ const array_cat_2 = [_]u8{0} ++ [1]u8{1};
 const array_cat_3 = [1]u8{0} ++ [1]u8{1};
 //    ^^^^^^^^^^^ ([2]u8)()
 
-// TODO this should be `*const [5]u8`
 const array_cat_4 = &[2]u8{ 0, 1 } ++ &[3]u8{ 2, 3, 4 };
-//    ^^^^^^^^^^^ (*[5]u8)()
+//    ^^^^^^^^^^^ (*const [5]u8)()
 
 //
 // Array multiplication
@@ -108,9 +110,8 @@ const array_mult_0 = [_]u8{0} ** 2;
 const array_mult_1 = [1]u8{0} ** 2;
 //    ^^^^^^^^^^^^ ([2]u8)()
 
-// TODO this should be `*const [6]u8`
 const array_mult_2 = &[3]u8{ 0, 1, 2 } ** 2;
-//    ^^^^^^^^^^^^ (*[6]u8)()
+//    ^^^^^^^^^^^^ (*const [6]u8)()
 
 comptime {
     // Use @compileLog to verify the expected type with the compiler:

tests/lsp_features/inlay_hints.zig

@@ -243,7 +243,7 @@ test "var decl" {
         \\const foo<@TypeOf(undefined)> = undefined;
     , .{ .kind = .Type });
     try testInlayHints(
-        \\const foo<**const [3:0]u8> = &"Bar";
+        \\const foo<*const *const [3:0]u8> = &"Bar";
     , .{ .kind = .Type });
     try testInlayHints(
         \\const foo: *[]const u8 = &"Bar";