Some improvements to hover text#2277
Merged
Merged
Conversation
FnControlOption
force-pushed
the
hover-go-to
branch
5 times, most recently
from
91bcea2 to
6b4fc40
Compare
FnControlOption
force-pushed
the
hover-go-to
branch
2 times, most recently
from
382f6b0 to
c0fa5ba
Compare
Techatrix
requested changes
May 4, 2025
Member
|
Why has this been converted into a draft? Is it waiting for #2296 perhaps? |
Contributor
Author
Yes, but we can merge this one first if you prefer |
FnControlOption
force-pushed
the
hover-go-to
branch
from
718e00a to
3ed9f05
Compare
FnControlOption
commented
May 8, 2025
| \\) void | ||
| \\``` | ||
| \\```zig | ||
| \\(unknown) |
Contributor
Author
There was a problem hiding this comment.
I have another PR in the works: FnControlOption/zls@8d5878bb (Will open after this one is merged)
FnControlOption
force-pushed
the
hover-go-to
branch
from
3ed9f05 to
ad6f247
Compare
FnControlOption
force-pushed
the
hover-go-to
branch
from
ad6f247 to
6187495
Compare
Techatrix
approved these changes
May 10, 2025
Techatrix
left a comment
Techatrix
left a comment
Member
There was a problem hiding this comment.
Not sure how I feel about bringing back the resolved function type after it has been removed in #1377. I suppose it a matter of personal preference about how much information you would like to see in the hover popup.
I have recently found a possible solution to this problem that could become useful in the future. I will follow up about it in a new issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std.fmtAnalyser.addReferencedTypeswithType.format, which has pretty much the same logic but also handles generic types