Skip to content

resolve return type of function with invalid parameter #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techatrix merged 1 commit into from
May 8, 2025
Merged

resolve return type of function with invalid parameter #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/analysis.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2264,20 +2264,20 @@ fn resolveTypeOfNodeUncached(analyser: *Analyser, node_handle: NodeWithHandle) e
param_name = tree.tokenSlice(name_token);
}

const param_type = blk: {
if (param.type_expr) |type_expr| {
const param_type = param_type: {
if (param.type_expr) |type_expr| blk: {
const ty = try analyser.resolveTypeOfNode(.of(type_expr, handle)) orelse {
return null;
break :blk;
};
if (!ty.is_type_val) {
return null;
break :blk;
}
break :blk ty;
break :param_type ty;
}
if (param.anytype_ellipsis3) |token_index| {
switch (tree.tokenTag(token_index)) {
.keyword_anytype => {
break :blk null;
break :param_type null;
},
.ellipsis3 => {
has_varargs = true;
Expand All @@ -2286,7 +2286,7 @@ fn resolveTypeOfNodeUncached(analyser: *Analyser, node_handle: NodeWithHandle) e
else => unreachable,
}
}
return null;
break :param_type Type.fromIP(analyser, InternPool.Index.unknown_type, null);
};

try parameters.append(analyser.arena.allocator(), .{
Expand Down
13 changes: 13 additions & 0 deletions tests/lsp_features/completion.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,19 @@ test "function call" {
});
}

test "resolve return type of function with invalid parameter" {
try testCompletion(
\\fn Foo(foo: unknown) type {
\\ _ = foo;
\\ return struct { alpha: u32 };
\\}
\\var foo: Foo() = undefined;
\\const bar = foo.<cursor>
, &.{
.{ .label = "alpha", .kind = .Field, .detail = "u32" },
});
}

test "optional" {
try testCompletion(
\\const foo: ?u32 = undefined;
Expand Down