Skip to content

Print all errors (with line and column) when running analysis tests#2310

Merged
Techatrix merged 8 commits into
zigtools:masterfrom
FnControlOption:analysis
May 18, 2025
Merged

Print all errors (with line and column) when running analysis tests#2310
Techatrix merged 8 commits into
zigtools:masterfrom
FnControlOption:analysis

Conversation

@FnControlOption

Copy link
Copy Markdown
Contributor

I find it useful to get all test failures at once

@Techatrix Techatrix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to ErrorBuilder.zig should have test coverage. There are already some existing tests.

The error tracking in analysis_check.zig seems very useless. Why not just add something like this to end of the main function:

if (error_builder.hasMessages()) {
    return error.CheckFailed;
}

@Techatrix Techatrix merged commit 2822437 into zigtools:master May 18, 2025
6 checks passed
@FnControlOption FnControlOption deleted the analysis branch May 18, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants