Feat/add criteria filter algolia#437
Merged
zigzagdev merged 4 commits intoMay 3, 2026
Merged
Conversation
Allow callers to request inscription-criteria filtering on heritage search. The factory rejects values outside the i-x whitelist so invalid input fails fast before reaching Algolia. Also updates the consuming factory and search-heritages tests for the new constructor argument. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Without indexing the criteria attribute, any criteria facet filter would always return zero hits because the field would not exist on Algolia records. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Multiple selected criteria are joined with OR (criteria:i OR criteria:iv ...) so a request for "i or iv" returns heritage sites whose criteria contain either value, matching the certification-exam study flow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Wire criteria through the application and presentation layers so clients can pass criteria[]=i&criteria[]=iv on the search endpoint. The controller normalises a single string value into a one-element array for callers that send a non-array form. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zigzagdev
changed the base branch from
main
to
feat/search-criteria-and-endangered-filter
8 tasks
zigzagdev
merged commit cb464f0
into
feat/search-criteria-and-endangered-filter
25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.