Fix Presentation Layer Tests

[zigzagdev]

what i have done

• fix controller tests

[Copilot]

Pull Request Overview

This PR fixes presentation layer tests for the WorldHeritageController by updating test data structures and adding database management functionality. The main purpose is to align the test data with changes to the WorldHeritage data model that now includes state party information and removes UNESCO ID references.

• Updated test data from Japanese heritage sites to European/Asian transnational sites with state party metadata
• Added database seeding and cleanup functionality with proper foreign key constraint handling
• Removed UNESCO ID field references and added state party fields to match updated data model

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
WorldHeritageController_getByIdsTest.php	Updated test data structure, added database refresh logic, and modified assertions to match new data model
WorldHeritageController_getByIdTest.php	Updated test data, added database cleanup methods, and updated mock DTO to handle new state party fields

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Using env() directly in application code is discouraged. Use config('app.env') instead, as env() should only be used in configuration files.

Suggested change

	if (env('APP_ENV') === 'testing') {
	if (config('app.env') === 'testing') {

[Copilot]

Using env() directly in application code is discouraged. Use config('app.env') instead, as env() should only be used in configuration files.

Suggested change

	if (env('APP_ENV') === 'testing') {
	if (config('app.env') === 'testing') {

[Copilot]

Hard-coding the MySQL connection makes the tests less portable. Consider using the default connection or making it configurable for different database drivers.

Suggested change

	DB::connection('mysql')->statement('SET FOREIGN_KEY_CHECKS=0;');
	WorldHeritage::truncate();
	Country::truncate();
	DB::table('site_state_parties')->truncate();
	DB::connection('mysql')->statement('SET FOREIGN_KEY_CHECKS=1;');
	$connection = DB::connection();
	$driver = $connection->getDriverName();
	if ($driver === 'mysql') {
	$connection->statement('SET FOREIGN_KEY_CHECKS=0;');
	}
	WorldHeritage::truncate();
	Country::truncate();
	DB::table('site_state_parties')->truncate();
	if ($driver === 'mysql') {
	$connection->statement('SET FOREIGN_KEY_CHECKS=1;');
	}

[Copilot]

Hard-coding the MySQL connection makes the tests less portable. Consider using the default connection or making it configurable for different database drivers.

Suggested change

	DB::connection('mysql')->statement('SET FOREIGN_KEY_CHECKS=0;');
	WorldHeritage::truncate();
	Country::truncate();
	DB::table('site_state_parties')->truncate();
	DB::connection('mysql')->statement('SET FOREIGN_KEY_CHECKS=1;');
	DB::statement('SET FOREIGN_KEY_CHECKS=0;');
	WorldHeritage::truncate();
	Country::truncate();
	DB::table('site_state_parties')->truncate();
	DB::statement('SET FOREIGN_KEY_CHECKS=1;');

[zigzagdev]

Ok