update get dimensionality method.#361
Open
SamTov wants to merge 2 commits into
Open
Conversation
SamTov
commented
Oct 22, 2021
SamTov
left a comment
SamTov
left a comment
Member
Author
There was a problem hiding this comment.
Please address comments.
PythonFZ
requested changes
Oct 22, 2021
| dimensions = 3 | ||
|
|
||
| return dimensions | ||
| return np.where(box != 0, 0, 1, 0).sum() |
Member
Author
There was a problem hiding this comment.
It seems thre has actually been a test for this the whole time. One of the first added.
def test_get_dimensionality(self):
"""
Test the get_dimensionality method.
Returns
-------
assert that for all choices of dimension array the correct dimension comes out.
"""
one_d = [1, 0, 0]
two_d = [1, 1, 0]
three_d = [1, 1, 1]
assert get_dimensionality(one_d) == 1
assert get_dimensionality(two_d) == 2
assert get_dimensionality(three_d) == 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of additions and changes