[WIP] Fran graphs#518
Draft
Fratorhe wants to merge 10 commits into
Draft
Conversation
Member
|
@Fratorhe Maybe we can have a call next week or so and go over it together with the molecule mapping stuff somewhere in mind as it looks like there are some nice crossovers that we can take advantage of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should not be merged (YET).
I have a few questions and I think this is the easiest way to assess them.
I have implemented calculators for the search of neighbors per atom, and for the rings (initial development by Hamish).
The current implementation does not use TF (only numpy and scipy).
Questions:
self.queue_data(data=dict_neighbors_result, subjects=["System"]). But it would be nicer to have appropriate names (eg. rings or neighbors)Summary of additions and changes
How to test this pull request
Functional tests using a fullerene have been implemented. Further tests could be implemented using DataHub if needed.
The lammpstraj file added so far is very small.
In examples, I included as well a C59 structure (basically removing an atom from the C60).