Skip to content

fix: enable decoding of 256 bit numbers (#1053)#1134

Open
abhishek818 wants to merge 2 commits intozio:series/2.xfrom
abhishek818:decode_256_bit
Open

fix: enable decoding of 256 bit numbers (#1053)#1134
abhishek818 wants to merge 2 commits intozio:series/2.xfrom
abhishek818:decode_256_bit

Conversation

@abhishek818
Copy link
Copy Markdown

fixes #1053

/claim #1053

@abhishek818 abhishek818 requested a review from a team as a code owner June 28, 2024 14:20
@abhishek818
Copy link
Copy Markdown
Author

@jdegoes Up for review.

@abhishek818
Copy link
Copy Markdown
Author

abhishek818 commented Jun 28, 2024

I have simply reconfigured the limit to 256 here,
should we provide a config to set the limit (not sure how? also it can lead to other problems) OR
should I look in the direction of a custom decoder OR
or increase the const to some other higher no. ?

@jdegoes @987Nabil

@abhishek818
Copy link
Copy Markdown
Author

@jdegoes hey can you review this?

@fsvehla
Copy link
Copy Markdown
Contributor

fsvehla commented Sep 1, 2024

@abhishek818 Can you check what’s up with the huge diff in lexer.scala, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't decode 256bit numbers

2 participants