fix: don't drop cause-chain when rendering related errors as nested#473
Open
elkowar wants to merge 1 commit into
Open
fix: don't drop cause-chain when rendering related errors as nested#473elkowar wants to merge 1 commit into
elkowar wants to merge 1 commit into
Conversation
Previously, using the show_related_errors_as_nested feature introduced in 771a075, any cause-chain of those nested errors would be dropped, so the information would get lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sadly discovered a bug I overlooked in my PR #417 from a while ago, which meant that using the show-related-errors-as-nested feature would hide the cause chain of those related errors. This is obviously not desirable.
This PR fixes that ^^