Open
Conversation
Port to the current release of the `criterion` benchmark harness to address `cargo audit` warnings about transitive dependencies. The `benchmark_function_with_inputs` API has been deprecated since 0.3 and is removed in 0.4 and most benchmarks must therefore be ported to the new `BenchmarkGroup` type. Resolves - https://rustsec.org/advisories/RUSTSEC-2021-0127 - https://rustsec.org/advisories/RUSTSEC-2021-0145
Author
|
NB submitted this against Similar to dalek-cryptography#375 and brave-experiments#1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port to the current release of the
criterionbenchmark harness to addresscargo auditwarnings about transitive dependencies. Thebenchmark_function_with_inputsAPI has been deprecated since 0.3 and is removed in 0.4 and most benchmarks must therefore be ported to the newBenchmarkGrouptype.Resolves