HASH redefined (STM32)

[mjw6i]

Hello,

I wrote initial ZMK support for this little guy WeActStudio.STM32H5_64Pin_CoreBoard.
It's a board that is present in zephyr 4.1.

I'm pretty sure this will surface for different STM32 versions.
The issue, while tiny, will be annoying to workaround:

/tmp/zmk-config/zmk/app/include/dt-bindings/zmk/keys.h:128: warning: "HASH" redefined
In file included from /tmp/zmk-config/modules/hal/stm32/stm32cube/stm32h5xx/soc/stm32h5xx.h:107

You can currently see the full build log here (one with warnings)
https://github.com/mjw6i/zmk-caveman-config/actions/runs/33351292851/job/99365091466

It builds cleanly when the define is renamed
https://github.com/mjw6i/zmk-caveman-config/actions/runs/33350548778

I renamed it terribly just for demonstration
main...mjw6i:zmk:caveman

I don't have any suggestions as far as solutions go, but I'm pretty sure you've had this problem before.

[caksoylar]

Fixing it that way would be a breaking change that'd break a lot of keymaps. I guess this kind of thing was bound to happen when ugly prefixes like KC_ aren't used for keycodes. I can't think of any myself right now, but it'd be great if there was a better solution.

[Genteure]

Replacing the following

zmk/app/include/zmk/keys.h

Line 10 in 641514a

#include <dt-bindings/zmk/keys.h>

with

#include <dt-bindings/zmk/hid_usage.h>
#include <dt-bindings/zmk/hid_usage_pages.h>
#include <dt-bindings/zmk/modifiers.h>

still compiles with west build -b nice_nano//zmk -- -DSHIELD=tester_pro_micro.

It technically is still a breaking change but it wouldn't break keymaps, only C code that both includes zmk/keys.h and uses keycodes like E and HASH.