Name the documentation site as the packages' homepage - #111
Merged
Merged
Conversation
The npm page for @zoosky/accent-sass had no Homepage link, and neither did the three crates on crates.io. npm takes the link from package.json's `homepage`, which wasm-pack fills from the crate manifest, so the field goes in Cargo.toml: https://zoosky.github.io/accent-sass/. All three crates get it, so crates.io links the site from each. Checked: `cargo metadata` reports the homepage for accent_sass_compiler, accent-sass-macro and accent-sass, and a fresh `wasm-pack build --scope zoosky` writes it into package.json beside the repository URL. A registry cannot change the metadata of a version it already has, so the link appears with the next published version, not on 0.16.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The npm page for
@zoosky/accent-sassshows no Homepage link, and neither do the three crates on crates.io. npm reads the link from thehomepagefield inpackage.json, and wasm-pack generates that field from the crate manifest.What changes
homepagefield.crates/lib/Cargo.toml,crates/compiler/Cargo.tomlandcrates/accent-sass-macro/Cargo.tomleach sethomepage = "https://zoosky.github.io/accent-sass/", so crates.io links the site from every crate.[Unreleased].What was measured
cargo metadatareports the homepage foraccent_sass_compiler,accent-sass-macroandaccent-sass.wasm-pack build --scope zooskywrites"homepage": "https://zoosky.github.io/accent-sass/"intopackage.json, next to the repository URL.When it shows up
Neither registry lets you change the metadata of a version that is already published, so 0.16.0 keeps its current pages. The link appears with the next published version.
release.sh --npm-onlywill not republish 0.16.0 with this change: its source guard countscrates/lib/Cargo.tomlas released source. Publishing a new version is the only route.