Skip to content

Enhance dock visibility management with global polling and edge detection #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
massimiliano-dalcero wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance dock visibility management with global polling and edge detection #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cdb39b
Add global polling timer for dock visibility management
massimiliano-dalcero Apr 5, 2026
c80843a
Change monitor_num to a public property with getter
massimiliano-dalcero Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 97 additions & 3 deletions lib/HideManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ namespace Plank {
uint barrier_reveal_timer_id = 0U;
#endif

uint global_polling_timer_id = 0U;

/**
* Creates a new instance of a HideManager, which handles
* checking if a dock should hide or not.
Expand Down Expand Up @@ -152,6 +154,93 @@ namespace Plank {
wnck_screen.active_workspace_changed.connect_after (handle_workspace_changed);

setup_active_window (wnck_screen);

global_polling_timer_id = Gdk.threads_add_timeout (50, () => {
if (Disabled || controller.prefs.HideMode == HideType.NONE) return true;
if (barrier_reveal) return true;

int px, py;
controller.window.get_display ().get_default_seat ().get_pointer ().get_position (null, out px, out py);
unowned PositionManager pm = controller.position_manager;
var monitor = controller.window.get_screen ().get_display ().get_monitor (pm.monitor_num).get_geometry ();

int gap = pm.GapSize;

if (Hidden) {
bool touched = false;
int threshold = 3; // Give a generous 3 pixel hit-box for Wayland edges

switch (pm.Position) {
case Gtk.PositionType.BOTTOM:
if (py >= monitor.y + monitor.height - threshold) touched = true;
break;
case Gtk.PositionType.TOP:
if (py <= monitor.y + threshold) touched = true;
break;
case Gtk.PositionType.LEFT:
if (px <= monitor.x + threshold) touched = true;
break;
case Gtk.PositionType.RIGHT:
if (px >= monitor.x + monitor.width - threshold) touched = true;
break;
}

if (touched) {
Hovered = true;
update_hidden ();
}
} else {
// Mathematical bounds when visible.
// We expand the horizontal bounds to infinity so sliding sideways doesn't hide it.
// We expand the vertical bounds to INCLUDE the gap size plus a tiny buffer.
var win_rect = pm.get_dock_window_region ();
int rel_x = px - win_rect.x;
int rel_y = py - win_rect.y;

int hw_scale = 1;
unowned Gdk.Window? gdk_window = controller.window.get_window();
if (gdk_window != null) {
hw_scale = gdk_window.get_scale_factor();
}

var h_rect = pm.get_cursor_region ();
int buf = (gap + 5) * hw_scale;

switch (pm.Position) {
case Gtk.PositionType.BOTTOM:
h_rect.x = -999999;
h_rect.width = 1999999;
h_rect.height += buf;
break;
case Gtk.PositionType.TOP:
h_rect.x = -999999;
h_rect.width = 1999999;
h_rect.y -= buf;
h_rect.height += buf;
break;
case Gtk.PositionType.LEFT:
h_rect.y = -999999;
h_rect.height = 1999999;
h_rect.x -= buf;
h_rect.width += buf;
break;
case Gtk.PositionType.RIGHT:
h_rect.y = -999999;
h_rect.height = 1999999;
h_rect.width += buf;
break;
}

bool touched = (rel_x >= h_rect.x && rel_x < h_rect.x + h_rect.width && rel_y >= h_rect.y && rel_y < h_rect.y + h_rect.height);

if (!touched && Hovered) {
Hovered = false;
update_hidden ();
}
}

return true;
});
}

~HideManager () {
Expand All @@ -169,6 +258,11 @@ namespace Plank {
wnck_screen.active_window_changed.disconnect (handle_active_window_changed);
wnck_screen.active_workspace_changed.disconnect (handle_workspace_changed);

if (global_polling_timer_id > 0U) {
GLib.Source.remove (global_polling_timer_id);
global_polling_timer_id = 0U;
}

stop_timers ();

#if HAVE_BARRIERS
Expand Down Expand Up @@ -426,9 +520,9 @@ namespace Plank {
if ((bool) event.send_event)
return Gdk.EVENT_PROPAGATE;

if (Hovered) {
update_hovered_with_coords ((int) event.x, (int) event.y, true);
}
// if (Hovered) {
// update_hovered_with_coords ((int) event.x, (int) event.y, true);
// }

return Gdk.EVENT_PROPAGATE;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/PositionManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace Plank {
uint screen_changed_timeout_id;

Gdk.Rectangle monitor_geo;
int monitor_num;
public int monitor_num { get; private set; }
int last_update_monitor_num;

int max_hover_height_cache = 0;
Expand Down