Security: Sensitive AI provider API keys stored in localStorage#1166
Open
tuanaiseo wants to merge 1 commit intozuiidea:masterfrom
Open
Conversation
AI provider credentials (including `apiKey`) are persisted in `localStorage` via `saveAISettings`. Any XSS in the application or third-party script execution can read and exfiltrate these secrets. localStorage is not appropriate for long-lived sensitive tokens/keys. Affected files: aiConfig.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
|
@tuanaiseo is attempting to deploy a commit to the Zui Idea's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AI provider credentials (including
apiKey) are persisted inlocalStorageviasaveAISettings. Any XSS in the application or third-party script execution can read and exfiltrate these secrets. localStorage is not appropriate for long-lived sensitive tokens/keys.Severity:
highFile:
src/pages/ai/aiConfig.tsSolution
Do not store raw API keys in browser localStorage. Move model-provider calls behind a backend proxy and keep provider secrets server-side. If client-side storage is unavoidable, reduce risk with short-lived scoped tokens, strict CSP, and avoid persisting secrets at rest.
Changes
src/pages/ai/aiConfig.ts(modified)Testing