Security: Client-side-only authorization filtering for menu/routes#1167
Open
tuanaiseo wants to merge 1 commit intozuiidea:masterfrom
Open
Conversation
…menu/ Authorization appears to be enforced primarily by filtering UI menu items based on `currentAdmin.permissions`. This is a presentation-layer control and can be bypassed by directly navigating to routes or invoking APIs from the browser/devtools unless the server independently enforces authorization. Affected files: PrimaryLayout.tsx Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
|
@tuanaiseo is attempting to deploy a commit to the Zui Idea's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Authorization appears to be enforced primarily by filtering UI menu items based on
currentAdmin.permissions. This is a presentation-layer control and can be bypassed by directly navigating to routes or invoking APIs from the browser/devtools unless the server independently enforces authorization.Severity:
mediumFile:
src/layouts/PrimaryLayout.tsxSolution
Treat frontend permission checks as UX only. Enforce route/API authorization on the backend for every protected resource. Optionally add route guards that validate permission claims before rendering sensitive pages.
Changes
src/layouts/PrimaryLayout.tsx(modified)Testing