model: Use "direct" type for DMs on servers at feature level 174+#1635
Open
IlijevskiM wants to merge 1 commit intozulip:mainfrom
Open
model: Use "direct" type for DMs on servers at feature level 174+#1635IlijevskiM wants to merge 1 commit intozulip:mainfrom
IlijevskiM wants to merge 1 commit intozulip:mainfrom
Conversation
zulipbot
added
size: M
Zulip servers at API feature level 174 (Zulip 7.0) introduced "direct" as the preferred value for the `type` parameter of POST /messages when sending direct messages, replacing "private". Servers at this level still accept "private" for backwards compatibility, but older servers do not accept "direct". We now check `server_feature_level` against a named constant (DIRECT_MESSAGE_TYPE_FEATURE_LEVEL = 174) and send "direct" for newer servers and "private" for older ones. Fixes zulip#1388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zulip servers at API feature level 174 (Zulip 7.0) introduced "direct" as the preferred value for the
typeparameter when sending direct messages via POST /messages. Older servers require "private" and do not accept "direct".This change:
PrivateComposition.typetoLiteral["private", "direct"]DIRECT_MESSAGE_TYPE_FEATURE_LEVEL = 174inmodel.pysend_private_message()on the feature levelFixes #1388