Security: Insecure deserialization of untrusted network data using pickle#1135
Open
tuanaiseo wants to merge 1 commit intozyddnys:mainfrom
Open
Conversation
The server deserializes data from HTTP responses with `pickle.loads(await response.read())`. If the upstream endpoint is compromised or attacker-controlled, this enables arbitrary code execution during deserialization. Affected files: sent_data_internal.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The server deserializes data from HTTP responses with
pickle.loads(await response.read()). If the upstream endpoint is compromised or attacker-controlled, this enables arbitrary code execution during deserialization.Severity:
criticalFile:
server/sent_data_internal.pySolution
Do not use pickle for network payloads. Replace with a safe format (JSON/msgpack/protobuf) and strict schema validation. If binary transport is required, use signed payloads plus allowlisted types and never deserialize untrusted bytes directly.
Changes
server/sent_data_internal.py(modified)Testing