fix: set header snippets for websocket upgrade on nginx-ingress#7881
Merged
Conversation
Contributor
|
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deployments
|
agoose77
commented
Mar 9, 2026
Comment on lines
+16
to
+17
| nginx.org/server-snippets: | | ||
| resolver_timeout 30s; |
Contributor
Author
There was a problem hiding this comment.
It looks like NGINX caches the DNS responses by default, whereas the existing ingress-nginx uses the /etc/resolve to set a resolver with 30s TTL.
Contributor
Author
|
@yuvipanda I pinged you for review. This feels a bit like whack-a-mole — I wonder whether we should do a more systematic comparison of the resolved nginx configurations (I've been using them to guess what's missing). |
Member
|
@agoose77 whackamole is fine for now. Let's do this and see if this solves the issue? I think the resolved nginx config will have too much accidental differences |
Contributor
Author
Yeah, they're fairly different! |
github-project-automation
Bot
moved this from In progress
to Done
in Product and Services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ktyle reported that kernels and terminals weren't working properly on the Pythia BinderHub. He also saw 502 errors. Both of these, I reproduced.
We recently upgraded that hub to use nginx-ingress, and it turns out that our current configuration does not support websocket upgrades.
This PR sets the location snippet required to support that. There may be other configuration we need to tweak here (like buffering, timeouts, etc).
It also sets a TTL on DNS replies to match the old ingress defaults.