Skip to content

fix: set header snippets for websocket upgrade on nginx-ingress #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agoose77 merged 2 commits into from
Mar 9, 2026
Merged

fix: set header snippets for websocket upgrade on nginx-ingress #7881

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0cbbd3
fix: set header snippets for websocket upgrade on nginx-ingress
agoose77 Mar 9, 2026
b1b3170
fix: set DNS resolver timeout
agoose77 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions helm-charts/basehub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ binderhub-service:
annotations:
nginx.ingress.kubernetes.io/proxy-body-size: 256m
cert-manager.io/cluster-issuer: letsencrypt-prod
nginx.org/server-snippets: |
resolver_timeout 30s;
Comment on lines +16 to +17

@agoose77 agoose77 Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like NGINX caches the DNS responses by default, whereas the existing ingress-nginx uses the /etc/resolve to set a resolver with 30s TTL.

nodeSelector:
hub.jupyter.org/node-purpose: core
service:
Expand Down Expand Up @@ -431,6 +433,12 @@ jupyterhub:
ingressClassName: nginx
annotations:
nginx.ingress.kubernetes.io/proxy-body-size: 256m
# Handle websocket upgrades in nginx-ingress
nginx.org/location-snippets: |
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $connection_upgrade;
nginx.org/server-snippets: |
resolver_timeout 30s;
cert-manager.io/cluster-issuer: letsencrypt-prod
scheduling:
# We declare matchNodePurpose=require to get a nodeAffinity like a
Expand Down
Loading