filtering: remove debug.FreeOSMemory after engine rebuild - #8590
Open
ChenYun10 wants to merge 2 commits into
Open
filtering: remove debug.FreeOSMemory after engine rebuild#8590ChenYun10 wants to merge 2 commits into
ChenYun10 wants to merge 2 commits into
Conversation
Calling debug.FreeOSMemory forces a full stop-the-world GC and returns all free memory to the OS. This causes a sudden I/O and CPU spike right after saving settings (when the filtering engine is rebuilt), which on hosts with limited disk I/O such as cloud VMs can make the process appear to hang. Rely on the Go runtime scavenger, which returns memory to the OS gradually without the spike. Signed-off-by: Chen Yun <ChenYun10@users.noreply.github.com>
The forced GC and memory return can hang or crash the process on any host, not just hosts with limited disk I/O. Signed-off-by: Chen Yun <ChenYun10@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Saving settings rebuilds the filtering engine, and
initFilteringcallsdebug.FreeOSMemoryafterwards.FreeOSMemoryforces a full stop-the-world GC and returns all free memory to the OS, which causes a sudden CPU and I/O spike that can hang or crash the process right after a settings change — on any host (dedicated machines included), even with a small data volume.Fix
Remove the
debug.FreeOSMemorycall and rely on the Go runtime scavenger, which returns memory to the OS gradually without the spike.Notes
FreeOSMemorycall in the codebase.go build ./internal/filtering/andgo test ./internal/filtering/pass.Signed-off-by: Chen Yun ChenYun10@users.noreply.github.com