Skip to content

filtering: remove debug.FreeOSMemory after engine rebuild #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChenYun10 wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −4
Open

filtering: remove debug.FreeOSMemory after engine rebuild #8590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60b9d32
filtering: remove debug.FreeOSMemory after engine rebuild
ChenYun10 Sep 3, 2026
ccebe6d
filtering: clarify FreeOSMemory removal note
ChenYun10 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions internal/filtering/filtering.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"os"
"path/filepath"
"runtime"
"runtime/debug"
"slices"
"strings"
"sync"
Expand Down Expand Up @@ -770,9 +769,11 @@ func (d *DNSFilter) initFiltering(ctx context.Context, allowFilters, blockFilter
d.filteringEngineAllow = filteringEngineAllow
}()

// Make sure that the OS reclaims memory as soon as possible.
debug.FreeOSMemory()

// NOTE: Don't call debug.FreeOSMemory here. It forces a full
// stop-the-world GC and returns all free memory to the OS, which causes a
// sudden CPU and I/O spike that can hang or crash the process right after
// a settings change, on any host. The Go runtime scavenger already
// returns memory to the OS gradually without the spike.
d.logger.DebugContext(ctx, "initialized filtering engine")

return nil
Expand Down