fix: weapon - #43
Merged
Merged
Conversation
AhmedSobhy01
force-pushed
the
feat/model-loader
branch
from
April 19, 2026 14:18
f66ffc9 to
3948c20
Compare
AhmedAmrNabil
force-pushed
the
fix/weapon
branch
2 times, most recently
from
April 19, 2026 18:28
cc5066c to
fedd6a4
Compare
AhmedAmrNabil
force-pushed
the
fix/weapon
branch
from
April 20, 2026 20:25
1e15baa to
d96760b
Compare
LoayAhmed304
approved these changes
Apr 21, 2026
AhmedSobhy01
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr adds weapon component that will be used for shooting system later but mainly added now to fix rendering of the weapon inside walls by having a separate list of commands to render the weapons after everything else is rendered and resetting the depth buffer