-
Notifications
You must be signed in to change notification settings - Fork 3
fix: weapon #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: weapon #43
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
de91dde
feat(weapon): add WeaponComponent with correct rendering
AhmedAmrNabil 5a00cb2
fix(renderer): remove depth mask setting for weapon rendering
AhmedAmrNabil 5fa769b
feat(weapon): add maxAmmo, reloadTime, and currentAmmo to WeaponCompo…
AhmedAmrNabil e58ac4e
feat(config): add new weapon params and fix player hierarchy
AhmedAmrNabil d96760b
fix(config): correct JSON structure for health component children
AhmedAmrNabil f1c0b40
fix(renderer): enable depth mask before clear to ensure its cleared
AhmedAmrNabil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #include "weapon.hpp" | ||
|
|
||
| namespace gameplay { | ||
|
|
||
| void WeaponComponent::deserialize(const nlohmann::json& data) { | ||
| if (!data.is_object()) { | ||
| return; | ||
| } | ||
| damage = data.value("damage", 0); | ||
| range = data.value("range", 0.0f); | ||
| fireRate = data.value("fireRate", 0.0f); | ||
| maxAmmo = data.value("maxAmmo", 0); | ||
| reloadTime = data.value("reloadTime", 0.0f); | ||
| currentAmmo = maxAmmo; // Initialize current ammo to max ammo when deserialized | ||
| } | ||
|
|
||
| } // namespace gameplay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #pragma once | ||
|
|
||
| #include <ecs/component.hpp> | ||
|
|
||
| namespace gameplay { | ||
|
|
||
| class WeaponComponent : public our::Component { | ||
| public: | ||
| int damage; | ||
| float range; | ||
| float fireRate; | ||
| int maxAmmo; | ||
| float reloadTime; | ||
| int currentAmmo; | ||
| static std::string getID() { | ||
| return "Weapon"; | ||
| } | ||
|
|
||
| void deserialize(const nlohmann::json& data) override; | ||
| }; | ||
|
|
||
| } // namespace gameplay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.