Multi Joint Robot Tests [AARD-1971] - #1188
Merged
Merged
Conversation
rutmanz
reviewed
Jul 7, 2025
rutmanz
left a comment
rutmanz
left a comment
Member
There was a problem hiding this comment.
I'm not super familiar with the mirabuf format but it might be nice to check that the joint types are being parsed correctly (like you have 4 revolute and 2 slider)
azaleacolburn
previously requested changes
Jul 8, 2025
BrandonPacewic
requested changes
Jul 9, 2025
BrandonPacewic
left a comment
BrandonPacewic
left a comment
Member
There was a problem hiding this comment.
If we can I would like it if we could add some in code documentation regarding the magic floating test robot design that we now have in the cloud. Something to describe the structure of the design in a bit more detail and where said robot can be viewed from a developer perspective.
Dhruv-0-Arora
approved these changes
Jul 9, 2025
Co-authored-by: Brandon Pacewic <92102436+BrandonPacewic@users.noreply.github.com>
ryanzhangofficial
approved these changes
Jul 10, 2025
BrandonPacewic
approved these changes
Jul 10, 2025
BrandonPacewic
left a comment
BrandonPacewic
left a comment
Member
There was a problem hiding this comment.
Almost got all these tests done with now.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The physics system unit test and mirabuf parser unit test were timing out when importing the 2471 robot due to the file size being to large. A new robot model was created that has all the joints but a small file size, allowing fast testing.
Testing Done
JIRA Issue