Skip to content

Bug: Hides touch control schemes if not supported by device AARD-1958 - #1201

Merged
BrandonPacewic merged 12 commits into
devfrom
dhruv/1958/touch-scheme-hidden
Jul 10, 2025
Merged

Bug: Hides touch control schemes if not supported by device AARD-1958#1201
BrandonPacewic merged 12 commits into
devfrom
dhruv/1958/touch-scheme-hidden

Conversation

@Dhruv-0-Arora

@Dhruv-0-Arora Dhruv-0-Arora commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator

Task

AARD-1958

Prevent all touch control schemes to appear in the ChooseInputSchemePanel when spawning a robot if the device does not support touch capabilities.

Symptom

If on any device, if spawning a robot assembly, the ChooseInputSchemePanel includes the "Brandon" touch control scheme. If selected, this scheme spawns in touch control joysticks which are impractical on a non-touch device. The only way to remove these is to clear all preferences since the MainHUD touch control button is hidden to all non-touch devices.

Solution

Hides all touch control schemes if on a non-touch device.

Verification

To test:

  1. Spawn a robot on a non-touch device and look for the "Brandon" control scheme.
  2. Reload the page
  3. Inspect the web page
  4. click the "device toolbar button" in the top left of the inspect panel
    Screenshot 2025-07-08 at 3 11 18 PM
  5. Retest step 1 and see the "Brandon" control scheme appear.

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@Dhruv-0-Arora Dhruv-0-Arora self-assigned this Jul 8, 2025
@Dhruv-0-Arora
Dhruv-0-Arora requested review from a team as code owners July 8, 2025 22:12
@Dhruv-0-Arora
Dhruv-0-Arora requested a review from PepperLola July 8, 2025 22:12
@Dhruv-0-Arora Dhruv-0-Arora added the bug Fixes an issue label Jul 8, 2025
@Dhruv-0-Arora Dhruv-0-Arora added the gameplay Relating to the playability of Synthesis label Jul 8, 2025
Comment thread fission/src/ui/panels/configuring/initial-config/InputSchemeSelection.tsx Outdated

@ryanzhangofficial ryanzhangofficial left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread fission/src/ui/panels/configuring/initial-config/InputSchemeSelection.tsx Outdated
Comment thread fission/src/ui/panels/configuring/initial-config/InputSchemeSelection.tsx Outdated
Co-authored-by: Azalea Colburn <62953415+azaleacolburn@users.noreply.github.com>
@Dhruv-0-Arora
Dhruv-0-Arora force-pushed the dhruv/1958/touch-scheme-hidden branch from 3c524b5 to 766e69b Compare July 9, 2025 23:44
@BrandonPacewic BrandonPacewic mentioned this pull request Jul 10, 2025
@BrandonPacewic
BrandonPacewic merged commit 86b3d49 into dev Jul 10, 2025
17 checks passed
@BrandonPacewic
BrandonPacewic deleted the dhruv/1958/touch-scheme-hidden branch July 10, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes an issue gameplay Relating to the playability of Synthesis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants