Make Global Functions Non-Optional [AARD-1986] - #1204
Merged
Conversation
AlexD717
approved these changes
Jul 9, 2025
Dhruv-0-Arora
approved these changes
Jul 9, 2025
Merged
BrandonPacewic
approved these changes
Jul 10, 2025
BrandonPacewic
left a comment
Member
There was a problem hiding this comment.
Love stuff like this, nice clear win for the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
AARD-1986
Very small task to improve the typing on the
Global_*functionsSymptom
Currently the
Global_DoWhateverfunctions are typed as potentially undefined and require optional chaining (Global_DoWhatever?.(...)) whenever they're called. This is ugly and somewhat unintuitive because these functions are, in practice, always defined when they'd be calledSolution
I provided a default
() => {}implementation so that they're always callable and don't include undefined in their type signatureVerification
Type checking handles most of it, and I ran synthesis and checked that toasts still worked (they did)
Before merging, ensure the following criteria are met: