Scene System Testing [AARD-1938] - #1217
Conversation
rutmanz
left a comment
rutmanz
left a comment
There was a problem hiding this comment.
I'm only about halfway done reading through this but I'm concerned that a lot of the tests here aren't really checking for things that matter. Like #1179, it kind of feels like these might be AI generated, and I'm not sure what a lot of them are doing
I did use AI to help make these unit tests, and I thought that I looked through them and fixed all the mistakes. I have clearly missed some, so I will go through again and double check that everything is good. |
|
|
||
| public setTargetCoordinates(coords: Partial<SphericalCoords>) { | ||
| if (coords.theta !== undefined) this._nextCoords.theta = coords.theta | ||
| if (coords.phi !== undefined) this._nextCoords.phi = coords.phi | ||
| if (coords.r !== undefined) this._nextCoords.r = coords.r | ||
| } | ||
|
|
||
| public setImmediateCoordinates(coords: Partial<SphericalCoords>) { |
There was a problem hiding this comment.
Why are we removing this function?
There was a problem hiding this comment.
This function was added in the view cube pr, but it isn't actually used anywhere in the code. It also only moves the camera towards the target coordinates for only one frame and then stops.
6 participants
Task
Create unit tests for each element found in
fission/src/systems/scene/.AARD-1938
Symptom
No unit tests currently exist for elements in
fission/src/systems/scene/.Solution
Create unit test for each element in
fission/src/systems/scene/.Note: No unit tests were created for SceneObject.ts due to it being very simple and other tests already testing its functionality.
Verification
All unit tests pass
Before merging, ensure the following criteria are met: