Skip to content

Bootstrap Unit Tests [AARD-1942] - #1226

Merged
BrandonPacewic merged 14 commits into
devfrom
zachr/1942/bootstrap-tests
Jul 22, 2025
Merged

Bootstrap Unit Tests [AARD-1942]#1226
BrandonPacewic merged 14 commits into
devfrom
zachr/1942/bootstrap-tests

Conversation

@rutmanz

@rutmanz rutmanz commented Jul 18, 2025

Copy link
Copy Markdown
Member

Task

AARD-1942

Write unit tests for app startup and bootstrapping

Symptom

Validate that the whole loading/rendering pipeline from main.tsx down to all the components works as expected

Solution

While the original two pull requests (#1175 and #1179) were more verbose, I think that this version covers the use cases we care about. The idea is to capture the important parts of boostrapping without being obnoxious when anything normal changes

  • Google Analytics script loading
  • That mounts
  • That there are no expected DOM elements that are missing (try changing the IDs of the expected joystick elements in InputSystem.ts#L201)
  • That the worldInit function is called (i.e. we get to the start of World.test.ts)
  • External CSS loading (TODO)

Verification

Go around messing with things that you think should be in scope (causing errors on startup, messing with main.tsx, breaking the main menu screen, etc, and see if the tests are passing.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz rutmanz self-assigned this Jul 18, 2025
@rutmanz rutmanz added the testing Relates to testing; anywhere from unit testing to E2E label Jul 18, 2025
@rutmanz
rutmanz marked this pull request as ready for review July 21, 2025 19:28
@rutmanz
rutmanz requested review from a team as code owners July 21, 2025 19:28

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Comment thread fission/src/index.css Outdated

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BrandonPacewic BrandonPacewic mentioned this pull request Jul 22, 2025
@BrandonPacewic
BrandonPacewic merged commit 09a41ce into dev Jul 22, 2025
16 checks passed
@BrandonPacewic
BrandonPacewic deleted the zachr/1942/bootstrap-tests branch July 22, 2025 01:32
PepperLola pushed a commit that referenced this pull request Jul 25, 2025
Co-authored-by: Zach Rutman <92497727+rutmanz@users.noreply.github.com>
Co-authored-by: Brandon Pacewic <92102436+BrandonPacewic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Relates to testing; anywhere from unit testing to E2E

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants