refactor(grzctl): set basic_qc_passed on successful validate#616
Merged
Conversation
Added a call to db.modify_submission after a successful validate to change basic_qc_passed to true
Ran uv run ruff format
Hoeze
requested changes
Jun 22, 2026
Hoeze
left a comment
Hoeze
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! 👍
Can you please add a test for this?
Collaborator
|
this one could fit: https://github.com/BfArM-MVH/grz-tools/blob/main/tests/test_validation.py |
Added a test within tests/cli/test_db_context.py
Collaborator
Author
|
Added in a test to tests/cli/test_db_context.py (test_validation_basic_qc_passed_update). I wasn't sure if I should create a completely new file for the test, or if it's cool to add it to an existing test file (I used a lot of the logic from test_db_context.py, which is why I added it there) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a call to db.modify_submission after a successful validate to change basic_qc_passed to true. Logically any submission which passes validation should have basic_qc_passed set as true.