Skip to content

test(worker): drain sandbox timeout fixtures - #354

Merged
outof-place merged 1 commit into
mainfrom
fix/poll-agent-full-suite-isolation-20260828
Aug 28, 2026
Merged

test(worker): drain sandbox timeout fixtures#354
outof-place merged 1 commit into
mainfrom
fix/poll-agent-full-suite-isolation-20260828

Conversation

@outof-place

Copy link
Copy Markdown
Collaborator

Follow-up to #353 / AWP-125.

Main CI run 33167983332 exposed a test-isolation race: timeout fixtures could leave an abandoned async sandbox collector alive, which later consumed the next test's one-shot runCommand mock and produced undefined.stdout.

This test-only patch:

  • waits until the intended mocked SDK call has started before advancing fake timers;
  • rejects and drains deferred timeout fixtures after assertions;
  • uses persistent stdout mock implementations so a delayed call cannot consume the current test's response;
  • keeps the mocked Sandbox import explicit.

Verification:

  • poll-agent.test.ts: 21/21, repeated 10/10 sequential runs
  • sandbox test directory: 465/465
  • worker TypeScript: pass
  • git diff --check: pass
  • fresh SolAdvisor review: SHIP

No production runtime files are changed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ai-workflow-app-dashboard Ready Ready Preview Aug 28, 2026 12:22pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b71ea8d-5168-4af9-bada-6e2862d0cc85


Comment @coderabbitai help to get the list of available commands.

@outof-place
outof-place merged commit 3f23d34 into main Aug 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant