Fix BlockEndPortalFrame#1493
Open
C1oky wants to merge 1 commit intoCloudburstMC:masterfrom
C1oky:master
Open
Conversation
wode490390
suggested changes
Jun 11, 2020
| for (int i = 0; i < 4; i++) { | ||
| for (int j = -1; j <= 1; j++) { | ||
| Block side = this.getSide(BlockFace.fromHorizontalIndex(i), 2).getSide(BlockFace.fromHorizontalIndex((i + 1) % 4), j); | ||
| if (this.isCompletedPortal(side)) { |
Contributor
There was a problem hiding this comment.
We should also check the direction of the frame block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building 4 frame enders for the portal in a row, the error java.lang.StackOverflowError popped up: null
LOG:
2020-06-11 20:25:04.165 [main] FATAL - Exception happened while ticking server
java.lang.StackOverflowError: null
at java.lang.StrictMath.floor(Unknown Source) ~[?:1.8.0_231]
at java.lang.Math.floor(Unknown Source) ~[?:1.8.0_231]
at cn.nukkit.math.Vector3.getFloorX(Vector3.java:44) ~[nukkit-1.0-SNAPSHOT.jar:?]
at cn.nukkit.level.Level.getBlock(Level.java:1507) ~[nukkit-1.0-SNAPSHOT.jar:?]
at cn.nukkit.block.BlockEndPortalFrame.searchCenter(BlockEndPortalFrame.java:123) ~[nukkit-1.0-SNAPSHOT.jar:?]
at cn.nukkit.block.BlockEndPortalFrame.searchCenter(BlockEndPortalFrame.java:127) ~[nukkit-1.0-SNAPSHOT.jar:?]
at cn.nukkit.block.BlockEndPortalFrame.searchCenter(BlockEndPortalFrame.java:127) ~[nukkit-1.0-SNAPSHOT.jar:?]