Skip to content

Frontend/i18n: Default localizeDateTime to the browser's timezone.#8124

Merged
tristanlabelle merged 1 commit into
developfrom
frontend/refactor/localizeDateTime-default-browser-tz
Mar 23, 2026
Merged

Frontend/i18n: Default localizeDateTime to the browser's timezone.#8124
tristanlabelle merged 1 commit into
developfrom
frontend/refactor/localizeDateTime-default-browser-tz

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Per @aapeliv's feedback. I was unconvinced by my own argument. :)

Left the explicit BROWSER_TIMEZONE in places where it's calling out #8064

Testing

Compared invite code dates on localhost vs next, they're the same.

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview Mar 18, 2026 8:41am

Request Review

@tristanlabelle
tristanlabelle marked this pull request as ready for review March 18, 2026 08:58
@tristanlabelle
tristanlabelle requested review from a team and aapeliv March 18, 2026 08:58

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tristanlabelle
tristanlabelle merged commit 1a6675d into develop Mar 23, 2026
12 checks passed
@tristanlabelle
tristanlabelle deleted the frontend/refactor/localizeDateTime-default-browser-tz branch March 23, 2026 03:00
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR makes a small frontend date-formatting cleanup so most dates default to the browser's timezone without needing an explicit parameter. While it may slightly improve consistency of displayed dates, it is a minor implementation change rather than a clearly noticeable end-user feature, significant UX improvement, or major technical infrastructure change.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR makes a small frontend date-formatting cleanup so most dates default to the browser's timezone without needing an explicit parameter. While it may slightly improve consistency of displayed dates, it is a minor implementation change rather than a clearly noticeable end-user feature, significant UX improvement, or major technical infrastructure change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants