Skip to content

Backend/push: Tweak host request notif for clarity#8494

Merged
aapeliv merged 2 commits into
developfrom
backend/bugfix/host-request-push-nights
May 9, 2026
Merged

Backend/push: Tweak host request notif for clarity#8494
aapeliv merged 2 commits into
developfrom
backend/bugfix/host-request-push-nights

Conversation

@tristanlabelle

Copy link
Copy Markdown
Contributor

Based on feedback counting the number of days as the number of nights + 1 is confusing. Change to counting the number of nights.

I decided against changing the string key since the placeholders didn't change. Translators will need to follow-up.

Testing

N/A - unfortunately this path is not easily testable.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented May 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 9, 2026 2:15pm

Request Review

@tristanlabelle
tristanlabelle marked this pull request as ready for review May 9, 2026 14:18
@tristanlabelle
tristanlabelle requested a review from aapeliv as a code owner May 9, 2026 14:18
@tristanlabelle
tristanlabelle requested a review from c-kreuz May 9, 2026 14:18
@aapeliv
aapeliv merged commit 85bd3e0 into develop May 9, 2026
9 checks passed
@aapeliv
aapeliv deleted the backend/bugfix/host-request-push-nights branch May 9, 2026 22:59
@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This is a minor wording/notification clarity tweak to an existing push notification, not a significant user-facing feature, major UX improvement, or important bug fix affecting core functionality.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This is a minor wording/notification clarity tweak to an existing push notification, not a significant user-facing feature, major UX improvement, or important bug fix affecting core functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants