This PR fixing a UI issue in the log in page for English language#8602
Merged
Conversation
Scenario: User attempts to log in with the correct username and the wrong password . The warning text would say "Wrong password" The text "Wrong password." now updated to say "Wrong Username/Email or Password." I updated the python tests as well Testing Images verification will be included. I checked different screen sizes, changes seem to be well. Web frontend checklist There are no console warnings when running the app Added tests where relevant Clicked around my changes running locally and it works Checked Desktop, Mobile and Tablet screen sizes For maintainers Maintainers can push commits to my branch Maintainers can merge this PR for me
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tristanlabelle
self-requested a review
May 15, 2026 13:41
tristanlabelle
left a comment
tristanlabelle
left a comment
Contributor
There was a problem hiding this comment.
You've covered all the right parts of the code, but also a few that shouldn't have been impacted. See comments.
… scenario. The change email and password scenarios reverted back to original.
1. Added a string in en.json for wrong username/email or password only for invalid password but correct username/email scenario. 2 Modified the test_auth py test to test the correct changes. 3. Ran all the py tests, everything works. Does not affect the other invalid password scenarios
tristanlabelle
approved these changes
May 15, 2026
tristanlabelle
left a comment
tristanlabelle
left a comment
Contributor
There was a problem hiding this comment.
Looks good! test_account changes are not necessary, but inoffensive.
github-actions
Bot
added
the
release notes: pending
Contributor
📝 Release NotesThis PR should be included in the release notes. Suggested release note: 🤖 Bot Debug InformationModel: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario:
User attempts to log in with the correct username and the wrong password . The warning text would say "Wrong password"
Issue: Someone can figure out if they have the right email since the system will tell them that, then they can figure out the password from there.
The text
"Wrong password." now updated to say "Wrong Username/Email or Password." I updated the python tests as well
Testing
I tested locally
Image attached
Web frontend checklist
For maintainers
Describe briefly what this PR is doing and why.
Testing
Explain how you tested this PR and give clear steps so the reviewer can replicate.