Skip to content

Frontend/i18n: Better app store badge string keys #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tristanlabelle merged 1 commit into from
May 18, 2026
Merged

Frontend/i18n: Better app store badge string keys #8669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/web/components/Footer/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ export default function Footer({ bottomMargin }: { bottomMargin?: string }) {
>
<img
src="/img/Download_on_the_App_Store_Badge_US-UK_RGB_blk_092917.svg"
alt={t("download_on_app_store")}
alt={t("app_store_badge_a11y")}
style={{ height: "26px", width: "auto", display: "block" }}
/>
</a>
Expand All @@ -277,7 +277,7 @@ export default function Footer({ bottomMargin }: { bottomMargin?: string }) {
>
<img
src="/img/GetItOnGooglePlay_Badge_Web_color_English.svg"
alt={t("get_it_on_google_play")}
alt={t("google_play_badge_a11y")}
style={{
height: "39px",
width: "auto",
Expand Down
4 changes: 2 additions & 2 deletions app/web/features/landing/CouchersIntroduction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function AppStoreBadges({ appStoreHeight = 38 }: { appStoreHeight?: number }) {
<a href={couchersAppStoreURL} target="_blank" rel="noopener noreferrer">
<img
src="/img/Download_on_the_App_Store_Badge_US-UK_RGB_blk_092917.svg"
alt={t("download_on_app_store")}
alt={t("app_store_badge_a11y")}
style={{
height: `${appStoreHeight}px`,
width: "auto",
Expand All @@ -51,7 +51,7 @@ function AppStoreBadges({ appStoreHeight = 38 }: { appStoreHeight?: number }) {
>
<img
src="/img/GetItOnGooglePlay_Badge_Web_color_English.svg"
alt={t("get_it_on_google_play")}
alt={t("google_play_badge_a11y")}
style={{
height: `${googlePlayHeight}px`,
width: "auto",
Expand Down
4 changes: 2 additions & 2 deletions app/web/resources/locales/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,6 @@
"a11y": "Kopieren",
"copied_tooltip": "In die Zwischenablage kopiert"
},
"download_on_app_store": "Im App Store herunterladen",
"get_it_on_google_play": "Bei Google Play herunterladen"
"app_store_badge_a11y": "Im App Store herunterladen",
"google_play_badge_a11y": "Bei Google Play herunterladen"
}
4 changes: 2 additions & 2 deletions app/web/resources/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"retract": "Retract",
"couchers": "Couchers.org",
"learn_more": "Learn more",
"download_on_app_store": "Download on the App Store",
"get_it_on_google_play": "Get it on Google Play",
Comment thread
tristanlabelle marked this conversation as resolved.
"app_store_badge_a11y": "Download on the App Store",
"google_play_badge_a11y": "Get it on Google Play",
"legal_name": "Couchers, Inc.",
"login": "Log in",
"sign_up": "Sign up",
Expand Down
Loading