Frontend/i18n: Better app store badge string keys#8669
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tristanlabelle
commented
May 18, 2026
tristanlabelle
marked this pull request as ready for review
May 18, 2026 07:03
c-kreuz
approved these changes
May 18, 2026
Contributor
📝 Release NotesThis PR does not need to be included in release notes. Reason: This PR only renames translation keys and adds translator context for app store badge accessibility text. It does not introduce a visible user-facing feature, significant UX improvement, or important technical infrastructure change that end users would notice. 🤖 Bot Debug InformationModel: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's important to provide context on the string keys because in this case the translation shouldn't be what translators come up with from the English string, but rather Google's official translations for those.
Added an explanatory string in weblate.
Filed #8670 to follow up on supporting localized badges.
Testing
N/A
Web frontend checklist
For maintainers