Skip to content

Frontend/i18n: Better app store badge string keys#8669

Merged
tristanlabelle merged 1 commit into
developfrom
frontend/bugfix/app-store-badge-a11y
May 18, 2026
Merged

Frontend/i18n: Better app store badge string keys#8669
tristanlabelle merged 1 commit into
developfrom
frontend/bugfix/app-store-badge-a11y

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented May 18, 2026

Copy link
Copy Markdown
Contributor

It's important to provide context on the string keys because in this case the translation shouldn't be what translators come up with from the English string, but rather Google's official translations for those.

Added an explanatory string in weblate.

Filed #8670 to follow up on supporting localized badges.

Testing

N/A

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented May 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 18, 2026 6:53am

Request Review

Comment thread app/web/resources/locales/en.json
@tristanlabelle
tristanlabelle marked this pull request as ready for review May 18, 2026 07:03
@tristanlabelle
tristanlabelle requested a review from nabramow as a code owner May 18, 2026 07:03
@tristanlabelle
tristanlabelle requested review from a team and c-kreuz May 18, 2026 07:04
@tristanlabelle tristanlabelle changed the title Frontend/landing: Improve app store badge string keys Frontend/i18n: Better app store badge string keys May 18, 2026
@tristanlabelle
tristanlabelle merged commit b448254 into develop May 18, 2026
12 checks passed
@tristanlabelle
tristanlabelle deleted the frontend/bugfix/app-store-badge-a11y branch May 18, 2026 07:32
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR only renames translation keys and adds translator context for app store badge accessibility text. It does not introduce a visible user-facing feature, significant UX improvement, or important technical infrastructure change that end users would notice.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR only renames translation keys and adds translator context for app store badge accessibility text. It does not introduce a visible user-facing feature, significant UX improvement, or important technical infrastructure change that end users would notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants