Backend/notifs: Make ChatMessage protos loc'able and port email#8753
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6103c27 to
4065812
Compare
4065812 to
af1c28e
Compare
|
Rebased to merge the list of unhandled enums in the default case of the match statement in render_email. |
📝 Release NotesThis PR does not need to be included in release notes. Reason: This PR mainly migrates chat notification emails to a new backend email system and makes them localizable. While users may eventually benefit from translated or more consistent chat emails, the change is mostly internal infrastructure work around email rendering and notification data, without a clearly visible new feature or major end-user behavior change described here. 🤖 Bot Debug InformationModel: |
Migrating the chat message notification emails to the new email system and making them localizable.
notifications_pb2.ChatMessageandChatMissedMessageto split out the non-localizablemessagefield into its constituents: group_chat_title and unseen_count. For backcompat with database entries containing old notifications, I parse these out of themessagefield if I have to.The
ChatMissedMessagesdesign is a little hacky because it includes a list of messages, but those are not all the missed messages, rather the last missed messages from all chats that have missed messages.Note: I duplicated the
view_actionstring for now but will do a pass to clean things up once I'm done porting emails.Testing
Dumped emails with
uv run dump-emails.Backend checklist
developif necessary for linear migration historyFor maintainers