Skip to content

fix(profile): sort localized tags using Chinese collation#9264

Merged
tristanlabelle merged 3 commits into
developfrom
frontend/bugfix/profile-tag-sorting-9228
Jul 22, 2026
Merged

fix(profile): sort localized tags using Chinese collation#9264
tristanlabelle merged 3 commits into
developfrom
frontend/bugfix/profile-tag-sorting-9228

Conversation

@HankAviator

Copy link
Copy Markdown
Contributor

Describe briefly what this PR is doing and why.

Fixes #9228

Testing

Explain how you tested this PR and give clear steps so the reviewer can replicate.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jul 11, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fb37e06cb--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fb37e06cb--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle tristanlabelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thanks! A few comments before we merge, or let me know if you want to hand it off to me.

Comment thread app/web/features/profile/ProfileTagInput.tsx Outdated
Comment thread app/web/features/profile/ProfileTagInput.tsx Outdated
Comment thread app/web/features/profile/ProfileTagInput.tsx Outdated
Comment thread app/web/features/profile/ProfileTagInput.test.ts Outdated
@HankAviator

Copy link
Copy Markdown
Contributor Author

Pushed a new commit to address all comments, thanks @tristanlabelle !

tristanlabelle
tristanlabelle previously approved these changes Jul 14, 2026

@tristanlabelle tristanlabelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread app/web/i18n/sorting.test.ts Outdated
@tristanlabelle
tristanlabelle merged commit ee37bd2 into develop Jul 22, 2026
7 checks passed
@tristanlabelle
tristanlabelle deleted the frontend/bugfix/profile-tag-sorting-9228 branch July 22, 2026 16:48
@github-actions github-actions Bot added the release notes: pending Add to stuff that should be included in release notes label Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR should be included in the release notes.

Suggested release note:

Fixed profile language and region tags sorting in Chinese so lists appear in a more natural, localized order
🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: include
Reasoning: This fixes a noticeable user-facing bug in profile tag lists for Chinese users by sorting localized language/region tags in a culturally appropriate order, improving usability of profile editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: pending Add to stuff that should be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Profile/i18n: Region/language list sorting is off

3 participants